kif-framework / KIF

Keep It Functional - An iOS Functional Testing Framework
Other
6.2k stars 909 forks source link

Update tappable to check if UIControl is enabled #1250

Closed dostrander closed 2 years ago

dostrander commented 2 years ago

In iOS 15 a control will still have tap gestures though it is disabled. This will check if it is a control and enabled while checking for the tap gestures.

This also re-adds back in https://github.com/kif-framework/KIF/pull/1244 with a condition of checking the control. Removing introduces a bug where KIF will say this something is not tappable when it is

Context for re-adding this check While I do think this check needs to be changed to accurately describe whether a view is tappable and on screen, my initial implementations did not work and would break in other ways. We need to think about what it means to be tappable on screen more clearly before removing/changing this check