kif-framework / KIF

Keep It Functional - An iOS Functional Testing Framework
Other
6.2k stars 909 forks source link

Bump iOS minimum iOS deployment target to 11.0 #1283

Closed danielob closed 3 months ago

danielob commented 1 year ago

I've noticed that when opening the project with Xcode 14.3, we get a warning that the target is not in the range of supported versions. Additionally, when trying to build the project using Carthage, we get a build error due to the deployment target being set to 8.0.

To address this issue, I've made changes to update the deployment target version to 11.0, which is within the range of supported deployment target versions for both Xcode and Carthage. This will ensure that the project can be built and run smoothly with the latest versions of Xcode and Carthage.

I've tested the changes locally and confirmed that they resolve the warning and error messages. Please review my changes and let me know if you have any feedback or concerns.

justinseanmartin commented 1 year ago

Looks like there are some deprecated APIs to work through before we can land this though:

▸ Compiling TestSuiteViewController.m

❌  /Users/runner/work/KIF/KIF/Test Host/TestSuiteViewController.m:108:1: implementing deprecated method [-Werror,-Wdeprecated-implementations]

- (void)actionSheet:(UIActionSheet *)actionSheet didDismissWithButtonIndex:(NSInteger)buttonIndex
^
danielob commented 1 year ago

Looks like the test host app is using the deprecated UIActionSheet. It is recommended to use UIAlertController instead. I can try to make these changes and update the tests. Also, I noticed the KIF tests target is failing to compile because is using some old openURL API. I will try to also fix this.

adamsousa commented 5 months ago

Any updates on merging this fix?

justinseanmartin commented 5 months ago

Sorry for dropping the ball, I'd seen the last message from Daniel, but didn't see the subsequent push with the compiler error fixes.

@danielob - Mind trying to push another commit to this PR branch and see if we can get green CI builds? For some reason the GH actions UI isn't letting me rekick it from the web.

If not, @adamsousa, would you potentially want to pick this up and get it over the line in a new PR?