search

kif-framework / KIF

Keep It Functional - An iOS Functional Testing Framework
Other
6.2k stars 909 forks source link

Bump ios minimum deployment target - New PR #1292

Closed adamsousa closed 3 months ago

adamsousa commented 3 months ago

New PR requested by @justinseanmartin

Original PR by @danielob #1283

adamsousa commented 3 months ago

@justinseanmartin Hmm, 3 checks were canceled almost imminently after creating the PR. Logs are unavailable to me so I'm not able to see what's going on.

justinseanmartin commented 3 months ago

Just needed approval to run. I hit the button on this, will see what comes out of the results. Thanks for picking this up!

justinseanmartin commented 3 months ago

First attempt failed with:

build (13.0, name=iPad Pro (12.9-inch) (5th generation),OS=15.0)

AccessibilityIdentifierPullToRefreshTests
    ✗ testPullToRefreshByAccessibilityIdentifier, The step timed out after 10.00 seconds: Failed to find accessibility element with the label "Bingo!"

build_xcode14 (14.1, name=iPad Pro (12.9-inch) (5th generation),OS=16.1)

AccessibilityIdentifierTests
    ✗ testEnteringTextIntoViewWithAccessibilityIdentifier, The step timed out after 10.00 seconds: Failed to find accessibility element with the label "Cut"

I'm re-running to see if these are just flakes, or if they're consistently broken in the same way.

justinseanmartin commented 3 months ago

Must've been flakes, because everything passed on re-run. Let me take a look at the code changes.