search

kif-framework / Lela

Lela iOS Perceptual Difference Testing Framework
GNU General Public License v3.0
73 stars 15 forks source link

Lela + use_frameworks! #20

Closed mrdekk closed 7 years ago

mrdekk commented 7 years ago

For some reason (I have Swift only framework in tests) I use use_frameworks! in cocoapods, so Lela is getting compiled to its own .framework So this function

+ (NSString *)directoryForExpectedImages
{
    return [[NSBundle bundleForClass:self] resourcePath];
}

returns path for Lela.framework, not the testing target but I have no means to override this from my test

mrdekk commented 7 years ago

Update:

  1. Interesting, but if I direct cocoapods to master branch, it works
  2. I've implemented a mean to supply resourceDir via options, if needed
mrdekk commented 7 years ago

but #19 seems to fix it better, and I think master works because of this

justinseanmartin commented 7 years ago

Is this needed if #19 fixes the same issue? Or are you just looking for a release with that fix in it?

mrdekk commented 7 years ago

Release would be good, but as for cocoapods I can use with a master branch. I think issue can be closed

justinseanmartin commented 7 years ago

Will create a release.

justinseanmartin commented 7 years ago

Done.