kii-chan-reloaded / RedTwiBot

A Reddit/Twitch bot that will update your subreddit statusbar when streamers are playing your sub's game
GNU General Public License v3.0
0 stars 0 forks source link

[Bug] Bot Spams Replies if Invalid Twitch Link #4

Closed EthanC closed 7 years ago

EthanC commented 7 years ago

This is a bit of a specific scenario, but I'll describe it the best I can so you can get it fixed.

We use our Reddit Bot account to create threads that all Moderators can edit when necessary. If Inbox Replies are left enabled, and another Moderator replies to that thread with a clips.twitch.tv link, the bot will spam the Invalid Stream Link reply until Shutdown, and the Notification is manually Marked as Read by a Moderator.

Two suggestions here:

  1. Disable responses for clips.twitch.tv links so it doesn't attempt (and fail) to add those links as Streamers
  2. Add a check to make sure the error reply is only sent once

As always, your work and help is very appreciated. Thank you!

kii-chan-reloaded commented 7 years ago

Should be fixed. Half of that was my own fault- I had commented out where it marks the failed messages as read during some testing, and apparently forgot to put it back in. The other half was that I hadn't thought about this sort of a situation when making it. I've made the bot completely ignore comments, user mentions, and messages from non-moderators, so that shouldn't be an issue anymore. Sorry for the oversight on my part!