kiibohd / KiiConf

Input Club web configurator, designed by matt3o.
http://configurator.input.club
GNU General Public License v3.0
92 stars 30 forks source link

WF can't compile a working matrix with online configurator #58

Open cubiq opened 8 years ago

cubiq commented 8 years ago

something seems off with the latest configurator and the whitefox. I get very weird results, the matrix seems shifted to the left of a couple of positions. burning an older firmware works without issues.

jbondeson commented 8 years ago

Are you trying import an older layout by chance?

In order to handle the multiple layouts of the WF without adding hidden keys or get really tricky at the compilation level I modified the KLL generation code to key off of the scan codes with commit 5ee6215 this allows for the diff algorithm to be able to correctly reduce to the base map even when some keys are missing. The unfortunate downside to that was any layout based on the older non-AllBlank layout were broken.

With new layouts created from scratch on the configurator we haven't seen issues like you've described yet.

cubiq commented 8 years ago

I believe I started from scratch, but the current system saves the latest layout (without asking which is a bit annoying). could it be that the new and old layouts got overlapped?

jbondeson commented 8 years ago

Very odd. I can probably tell from the JSON it's using. Would you mind throwing it in a gist?

As for the saving, it's definitely geared to the occasional user rather than more advanced I'm planning on switching that up a bit (HaaTa has suggested a "recent downloads" functionality that I like). The biggest consideration was to not lose work when refreshing the page.

cubiq commented 8 years ago

let me try to clean the browser cache and start over.

As per the auto-save I would instead add a "save" button, but that's just me.

jbondeson commented 8 years ago

The layouts are stored in local storage currently so the easiest it to just hit the "reset to default" button which returns to the stock layout for that keyboard variant.