kiibohd / KiiConf

Input Club web configurator, designed by matt3o.
http://configurator.input.club
GNU General Public License v3.0
92 stars 30 forks source link

"Simple macros" don't work on Mac OS Sierra #63

Closed rjhilgefort closed 8 years ago

rjhilgefort commented 8 years ago

I just upgraded to OSX Sierra to find that the "simple macros" I had configured through the input club layout layout builder no longer fire consistently (fire once every 20 key presses or something).

Anyone else having this issue? Is it a known issue- I couldn't find anything in the issues on this repo? Is this an issue I should be posting to the firmware repo instead?

rjhilgefort commented 8 years ago

Wasn't sure where the appropriate place was, so I created an issue over there as well:

https://github.com/benblazak/ergodox-firmware/issues/81

haata commented 8 years ago

Interesting. macOS Sierra had a lot of changes in the USB HID stack (karabiner has to be re-written due to them...).

rjhilgefort commented 8 years ago

Correction on cross post- posted to correct firmware repo (for infinity ergodox):

https://github.com/kiibohd/controller/issues/158

rjhilgefort commented 8 years ago

@haata Yeah, I'm fighting issues from that front as well. Both are killing my muscle memory, but I'm determined to hang on to Sierra and not downgrade. Any lead on a fix? If not, a work around?

haata commented 8 years ago

I'm getting really close to implementing the firmware support for KLL 0.4. So I'm torn between trying to hack up a fix for this or just add it as part of KLL 0.4.

I have an idea on how to fix this. It will change the behaviour of sequences for all platforms. The idea is to enable/disable modifiers exclusively then on the next packet deal with the non-modifier keys. USB HID spec wise, this is dumb. Stupid Apple.

rjhilgefort commented 8 years ago

Your call of course. Selfishly, I'd love a patch, depending on how far out KLL 0.4. I've grown pretty dependent on the simple macros and love what they allow for in my layout.

Yeah- does seem a bit silly, but I'm guessing the change is driven by the OLED touch "keys" that will replace the function keys above the numbers. Is that the case or is this change independent of that?

As I mentioned above, I created an issue on the kiibohd/controller repo which I'm guessing your involved with as well. Would it make sense to close that issue, or are there changes that will be required there as well.

kiibohd/controller#158

gibfahn commented 8 years ago

I think I'm seeing the same issue. If I use the Karabiner event viewer, when I use a Macro it's getting Ctrl instead of Shift (e.g. for % Karabiner is showing Ctrl 5 rather than Shift 5).

Just in case it helps...

haata commented 8 years ago

Does this still happen when karabiner is disabled?

@rjhilgefort @gibfahn

gibfahn commented 8 years ago

Ok, disabling Karabiner actually stops this issue from occurring. I also did Karabiner-Elements => Check for beta updates => install, and the new version has a Devices tab, so you can disable the Ergodox part, which fixed macros for me.

So based on this, should we raise an issue on the Karabiner Github page?

haata commented 8 years ago

Yeah, this sounds like a bug in karabiner. They are re-ordering keypresses for whatever reason. If you get push back, feel free to link me and I'll give a detailed technical explanation in the bug. Or if they want more details.

On Sun, Oct 30, 2016, 16:03 Gibson Fahnestock notifications@github.com wrote:

Ok, disabling Karabiner actually stops this issue from occurring. I also did Karabiner-Elements => Check for beta updates => install, and the new version has a Devices tab, so you can disable the Ergodox part, which fixed macros for me.

So based on this, should we raise an issue on the Karabiner Github page?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/kiibohd/KiiConf/issues/63#issuecomment-257186683, or mute the thread https://github.com/notifications/unsubscribe-auth/AABbqXpWdy9a7C5vjh6uN-LZe2OzPYyZks5q5SI5gaJpZM4KS6kq .

rjhilgefort commented 8 years ago

@gibfahn Can confirm that with Karabiner disabled, this issue isn't present. My apologies, should have eliminated that variable myself.

@haata Sounds good, I'll make one over there. Thanks for looking into this.