Animations wrap when column IDs are negative

kiibohd / controller

Kiibohd Controller

GNU General Public License v3.0

807 stars 270 forks source link

Animations wrap when column IDs are negative #277

Open gabeseltzer opened 6 years ago

gabeseltzer commented 6 years ago

K-Type: Purchased second-hand on Mechmarket
Firmware Origin: Windows Configurator
OS: Windows 10
Version: 1a14af7
Reproduction Steps: Create a reactive animation and set a frame to be offset a by a high negative number (ie P[r:i,c:i-36](255,255,255)).
Resulting Issue: If you press a key that isn't in the last row with this example, the animation will wrap to the right side of the board (this is consistent, not random).

haata commented 5 years ago

Interesting, definitely a bug. I'll need to check if there are array bounds checking, and also figure out how far negative columns should go (useful for interpolation calculations).