kiibohd / controller

Kiibohd Controller
GNU General Public License v3.0
807 stars 270 forks source link

Kira becomes unusable after creating fingerprints animation #321

Open thousand opened 5 years ago

thousand commented 5 years ago
keybeejeebee commented 5 years ago

You don't need to set fingerprints as a startup animation, the configurator actually shouldn't let you, but apparently does.

stoikos commented 5 years ago

Could you elaborate on that? How do we enable fingerprints otherwise if not as a startup?

thousand commented 5 years ago

Agreed, the intent is not clear in the configurator. I think it's working as intended with it added but not enabled as the startup animation.

keybeejeebee commented 5 years ago

The fingerprints animation is reactive, not a traditional animation. When you add the animation in the configurator, it adds custom kll to your config that tells the keyboard to play the animation each time a key is pressed. You can see the custom kll by hiding the visuals tab, and finding the custom kll tab in the lower left (it may have a different name in the new version, going by memory at current).

edit:

custom kll will look like this:

#~~~START ANIMATION (fingerprints_two_tone) INJECTION~~~#
S[0x00-0x5F] :+ A[fingerprints_two_tone](start);
#~~~END ANIMATION (fingerprints_two_tone) INJECTION~~~#
timbelshe commented 5 years ago

I think the issue is that some of us just want the fingerprint animation, and it seems odd that we can't just set that as the default when the keyboard starts up (without having to press some other key combination to activate it). Is there a way to let us to that (even if it's custom kll that we need to add), or is the current firmware not capable of this?

keybeejeebee commented 5 years ago

ok, try this. remove or deactivate all other animations besides the fingerprints and flash your board.

Type anything and you will see fingerprint animations.

You don't need to activate or set as default, it just works.

stoikos commented 5 years ago

That never works for me unfortunately. It always renders the keyboard completely useless - I get either crazy flashing LEDs or some other type of malfunction, most of the time it won't even register typing or even mess with my mouse for some reason (mouse getting very laggy). So unless I delete fingerprint and re-download the firmware I'm pretty much left with a non usable keyboard (and mouse) whenever I try this. Fingerprint just does not work for me at all no matter which way I try.

nick-solly commented 5 years ago

I'm experiencing exactly the same issue.

keybeejeebee commented 5 years ago

are you setting the fingerprints animation as startup? You should not do that, leave it unchecked, slid to the left, grey, whatever.

stoikos commented 5 years ago

No, everything is unchecked. I tried the startup thing as well as the proper way. Nothing works. It also makes no difference if it's the regular 'fingerprint' or 'two-tone-fingerprint'. I should say I also have a broken LED, not sure if that affects 'fingerprint' (it does not affect any other animation though).

nick-solly commented 5 years ago

Also have tried the above suggestions. I don't have a broken LED but still have the "fingerprint" issue.

timokoesters commented 5 years ago

I think the issue only arises when the name of the fingerprints animation is "fingerprints" as well. Try to change the name and see if it works.

stoikos commented 5 years ago

I think I initially tried changing the name during the first week and it didn't work. Now that I tried again, it sort of works, but only to a degree - meaning that it actually registers the fingerprint animation but the problem is that all LEDs are set to a pinkish colour until I actually start pressing keys. When I press a key the LED switches to the specific colour or two-tone that I chose for the fingerprint animation. But all other keys/LEDs that haven't been pressed yet still remain pink. Also, 4 specific keys/LEDs do not register the change at all, and just remain pink not matter how many times the keys are pressed (two arrow keys and 'insert' and 'delete'). So overall it's not really working. And no, I'm not using it as a start-up animation. This is on a Mac btw, haven't tried fingerprint on Windows yet. I might do that over the weekend and see if there's a difference.

Edit: I should add that pink is also the colour that shows when all start-up animations are turned off and without 'fingerprint' running.

mattkemp commented 5 years ago

I raised the four keys not working as a configurator issue as well https://github.com/kiibohd/configurator/issues/126

haata commented 5 years ago

The four keys should be fixed now https://github.com/smasher816/kiisrv/commit/432908a890e16771dbe0404224ac994748a35344

haata commented 5 years ago

I need to think more about how to make reactive animations "default". They are triggered in a fundamentally different way, so this will involve a combination of KLL, firmware and the configurator.

stoikos commented 5 years ago

Has the fix for the 4 keys already been implemented? I updated the firmware, but no change on my end. Other than that, it seems to be working fine.

mattkemp commented 5 years ago

I don't think the four key fix has made it into the latest firmware yet? Updated again today and still not working.

chasdevs commented 4 years ago

Also hit this same issue today.

Herkkupala commented 4 years ago

Faced same issue while updating to new firmware, I tried to paste the code over to kira_wave instead of a complete new animation, it just won't play the animation but the keyboard won't brick either. Instead it would show a static version of the previous animation.