kiibohd / kll

KLL Compiler
GNU General Public License v3.0
115 stars 68 forks source link

Off-by-one error in generated kll.json for Col/Row #22

Closed jbondeson closed 7 years ago

jbondeson commented 7 years ago

The generated Col/Row data seems to be shifted for both the PixelIds and ScanCodes nodes.

Output for K-Type scancode_map.p3.kll (not the non-existent 120)

        "1": {
            "Col": 36,
            "Row": 7,
            "ScanCode": 1,
            "x": 0.0,
            "y": 0.0,
            "z": 0.0
        },
        "2": {
            "Col": 1,
            "Row": 1,
            "ScanCode": 2,
            "x": 38.1,
            "y": 0.0,
            "z": 0.0
        },
[...]
        "119": {
            "Col": 0,
            "Row": 2,
            "x": -10.41,
            "y": 0.0,
            "z": 0.0
        },
        "120": {
            "Col": 0,
            "Row": 1
        }
jbondeson commented 7 years ago

Issue is resolved