search

kijai / ComfyUI-DynamiCrafterWrapper

Wrapper to use DynamiCrafter models in ComfyUI
Other
489 stars 15 forks source link

ToonCrafter flash between image transitions #40

Closed fofr closed 1 month ago

fofr commented 1 month ago

I'm noticing a dulling/fading between the image transitions in ToonCrafter outputs

Example video:

https://github.com/kijai/ComfyUI-KJNodes/assets/319055/9151b6ab-9ca7-4ff8-80c5-f3418f5e1df8

Each frame (with and without last image pruning)

Screenshot 2024-06-01 at 23 21 35 Screenshot 2024-06-01 at 23 22 23

Workflow (just a screenshot):

Screenshot 2024-06-01 at 23 24 49
kijai commented 1 month ago

This is due to the encoder/decoder ToonCrafter uses is designed to be used with xformers, I couldn't get it fully working without it and that first/last frame being gray mush is the exact result that happens when xformers is not used.

You can either install it (pip install xformers --no-deps), or alternatively simply replace the decoder node with a normal comfy VAE decoder, using any 1.5 VAE, which works without xformers with slight quality hit.

fofr commented 1 month ago

Thank you for the explainer, installing xformers fixed it 🙏