kijai / ComfyUI-KJNodes

Various custom nodes for ComfyUI
GNU General Public License v3.0
354 stars 47 forks source link

Browser Gets Stuck While Deleting Nodes | Also get stuck sometimes when connecting an empty GetNode #6

Open jerrydavos opened 7 months ago

jerrydavos commented 7 months ago

Screenshot 2023-12-05 124917 Screenshot 2023-12-05 124244

This custom node is like the best thing I found. It gave me a whole new perspective of making connections without making any noodles.

I want to help perfecting it, I found this error while using it. After all the nodes have been set up ( Get and Set Node) after saving it and restarting comfy with a clear canvas and Loading (drag and drop the file) in comfy. Then you can't delete the Set Nodes anymore. There is a permanent error of the Browser( See above screenshots) you can't make it disappear, nor restarting the comfy will fix it. No Comfy Ui buttons will work as the browser overtakes the UI.

This is can only be solved by clearing all the cache and Data of the past hour from the browser settings. but all the workflow is lost as you can't save it also.

I tried different browsers, same thing.

I am no pro coder but ill try to give some suggestion that can help :

1) Create a "null" ( with some value matching the connections ) as default for Get and Set node until the node pipe is complete in and out... so it won't say nothing found error and mismatch value error. 2) Undo the last action if some error comes or just break the last connection made. 3) If the script catches any error, output it in the console after running queue instead of browser error, so at least we can edit/save the workflow.

I hope this helps.

These Nodes are amazing, I specially made my first ever github acc to report this issue. because these nodes helps a lot in organizing and upped my workflow skills to a whole new level. but unfortunately because of this error I am avoiding because I have to update my workflows and these error won't let me :(

Step to reproduce this error :

Drag and drop this workflow and try deleting any setNode:

SVD_AD_Refiner_Beta.json

What is the above workflow about is here:
https://www.patreon.com/posts/ai-svd-with-more-93812677

kijai commented 7 months ago

Seems to me this is due to incompatibility with the "Use Everywhere" -nodes. I did manage reproduce it with the workflow you shared, got the browser stuck. Deleting the UE -node pack allowed me to just reload the workflow fine.

jerrydavos commented 7 months ago

I deleted that bad boy, still same error, can't delete nodes. 😭 .....One Thing I did was to disconnect the get/set node and calmly keep them in a corner, and never dare to disturb them again. They ANGRY!!!

kijai commented 7 months ago

There are lots of incompatibilities that I'm not able to resolve, they won't work with bypassed nodes, primitive nodes, the new node groups etc... I'm sure there are others especially with any node the uses javascript. That said, I've never had this kind of issue and I use them extensively in every workflow, I don't know what exactly is causing it for you. Does it happen in simpler workflows than that too?

jerrydavos commented 7 months ago

Well I mainly use comfyUi for animations, VHS , ControlNet, Comfyrolls, AnimateDiff Evolved, Efficiency node... ( and I just search & use which ever suits the best) from the node list :

Import times for custom nodes:
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\comfy_controlnet_preprocessors
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\gcLatentTunnel.py
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\SDXLAspectRatio.py
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Logic
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\SD-Latent-Upscaler
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\comfy-consistency-vae
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\sd-dynamic-thresholding
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\facedetailer
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_Noise
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\stability-ComfyUI-nodes
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_Cutoff
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUi_String_Function_Tree
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Advanced-ControlNet
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\IPAdapter-ComfyUI
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\comfy-image-saver
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale
   0.0 seconds (IMPORT FAILED): F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\DTAIComfyVariables
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Frame-Interpolation
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\efficiency-nodes-comfyui
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack
   0.0 seconds (IMPORT FAILED): F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_stable_fast
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Bmad-DirtyUndoRedo
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-KJNodes
   0.0 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\comfyui_controlnet_aux
   0.1 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_smZNodes
   0.1 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\failfast-comfyui-extensions
   0.7 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Manager
   0.9 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_FizzNodes
   1.3 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_InterpolateEverything
   1.5 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\was-node-suite-comfyui
   3.2 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
   4.9 seconds: F:\Stable Diffusion\Stability Matrix\Packages\ComfyUI\custom_nodes\ComfyUI_Custom_Nodes_AlekPet

I keep falling into that error more often when the workflow gets complicated,

Different Story : Once I by mistake looped the control net apply nodes into each other and it gave the same browser error :/

if comfy didn't give console error rather than browser error it can be a huge life saver, should I suggest this error into Comfy github, give console output error rather than browser error so it won't get stuck?