kijai / ComfyUI-LivePortraitKJ

ComfyUI nodes for LivePortrait
MIT License
1.55k stars 118 forks source link

Return type mismatch between linked nodes: image, LP_OUT != IMAGE #144

Open mwrkwng opened 3 weeks ago

mwrkwng commented 3 weeks ago

Prompt outputs failed validation ImageResizeKJ:

image

Issue started after updating ComfyUI-LivePortraitKJ from 2 months ago version to newest.

kexul commented 3 weeks ago

Same here.

Alesyte commented 2 weeks ago

Youp same

taloniousrex commented 1 week ago

same here

kijai commented 1 week ago

You are you using old workflow with new nodes, it just won't work, check the newer example workflows.

taloniousrex commented 1 week ago

That's it thanks! using the old example workflow generates the errors, new workflows examples are great. Thank you for response!

mwrkwng commented 1 week ago

You are you using old workflow with new nodes, it just won't work, check the newer example workflows.

Would be good if you could make your updates backwards compatible. Some people have big workflows and future updates shouldn't affect it

kijai commented 1 week ago

You are you using old workflow with new nodes, it just won't work, check the newer example workflows.

Would be good if you could make your updates backwards compatible. Some people have big workflows and future updates shouldn't affect it

Some features are not possible to keep backwards compatible, also it takes more time. The simplest solution to that issue is not to update.

taloniousrex commented 1 week ago

Not updating comfy ui is the trick I was missing. Thanks for that! Updating Comfyui blows everything up. I was able to delete and add the updated nodes in an old workflow to get things working. Not too tough. Would it be possible for you to post an example workflow with the animal settings? I keep getting an error face not recognized for any of the animal stuff i’m trying to test. I must be missing something in the node settings other than setting to animal? Thank you!

kijai commented 1 week ago

Not updating comfy ui is the trick I was missing. Thanks for that! Updating Comfyui blows everything up. I was able to delete and add the updated nodes in an old workflow to get things working. Not too tough. Would it be possible for you to post an example workflow with the animal settings? I keep getting an error face not recognized for any of the animal stuff i’m trying to test. I must be missing something in the node settings other than setting to animal? Thank you!

Are you saying the current version doesn't work with latest ComfyUI?

The animal detection would need the xpose detector and that's not implemented, mostly because it's not that simple to install (or at least last time I checked it required compiling stuff). The animal model that is implemented just makes it work better when the face is detected. For now the best you can do is use the Insightface detector and lower the detection threshold, it still probably won't work with animals that have less human like features though.

Or if you are working on animating single image, you can also try using matching human face in the detector and the animal face as the image to be morphed.

taloniousrex commented 1 week ago

KjLP is working fine in the current ComfyUI portable version. The suggestions on most boards is not to run the ‘update’ though -as in the install instructions, as it creates requirement conflicts between pytorch and other stuff. I’ve definitely broken ComfyUi custom nodes running the update in the past. I’m an artist trying to stay in the market and add tools to my quiver, so forgive if my description was poor. Picking up as much as I can as fast as I can. Really appreciate the notes on the animal face detection and insight face, that’ll keep me from wasting too much time thinking I’m the only one that can’t make it work.