kijai / ComfyUI-LivePortraitKJ

ComfyUI nodes for LivePortrait
MIT License
1.67k stars 128 forks source link

[ISSUE] Batching Video and Frames with 'No Face' cause unrecoverable error. #153

Open Wprussell opened 3 weeks ago

Wprussell commented 3 weeks ago

I'm sure you are aware, just starting a thread for this specific issue. "Live Portrait Retargeting" as well as just using "Live Portrait Process" by itself, is a bit of a kluge when it comes to batching video.

"Live Portrait Retargeting" just fails if there is a missing Face in frame passed from the Cropper. "Live Portrait Process" (Without Retargeting so it will work) will "Smooth" the frames so if there are a few missing, you get a fuzballblur. (Its an industry term) For the whole batch.. not just the missing frame..

As I said, Im sure you are aware - but if there was anything you would do about it I would be grateful.

Thanks Bunches..

kijai commented 3 weeks ago

There's a PR which may fix the issue, I just honestly haven't had the time (or interest) for this project at all, would help us all if you want to test it: https://github.com/kijai/ComfyUI-LivePortraitKJ/pull/115

Wprussell commented 3 weeks ago

Happy to test it, is it ready to go and do you need to resolve your conflicts?

BR.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jukka Seppänen @.> Sent: Sunday, November 3, 2024 11:06:09 AM To: kijai/ComfyUI-LivePortraitKJ @.> Cc: William Russell @.>; Author @.> Subject: Re: [kijai/ComfyUI-LivePortraitKJ] [ISSUE] Batching Video and Frames with 'No Face' cause unrecoverable error. (Issue #153)

There's a PR which may fix the issue, I just honestly haven't had the time (or interest) for this project at all, would help us all if you want to test it: #115https://github.com/kijai/ComfyUI-LivePortraitKJ/pull/115

— Reply to this email directly, view it on GitHubhttps://github.com/kijai/ComfyUI-LivePortraitKJ/issues/153#issuecomment-2453543323, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BI22TKHAUXYAVWAV2ZK7LOTZ6ZX2DAVCNFSM6AAAAABRC7B7GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU2DGMZSGM. You are receiving this because you authored the thread.Message ID: @.***>

Wprussell commented 2 weeks ago

Just following up, it works perfect, no issues that I can tell that didn't exist before, face outside of frame, morphing, etc. but regardless, does not throw errors and breezes through.

Thanks a bunch, I will update git as well with a comment.

Cheers Friend

Cruel_world

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Jukka Seppänen @.> Sent: Sunday, November 3, 2024 11:06:09 AM To: kijai/ComfyUI-LivePortraitKJ @.> Cc: William Russell @.>; Author @.> Subject: Re: [kijai/ComfyUI-LivePortraitKJ] [ISSUE] Batching Video and Frames with 'No Face' cause unrecoverable error. (Issue #153)

There's a PR which may fix the issue, I just honestly haven't had the time (or interest) for this project at all, would help us all if you want to test it: #115https://github.com/kijai/ComfyUI-LivePortraitKJ/pull/115

— Reply to this email directly, view it on GitHubhttps://github.com/kijai/ComfyUI-LivePortraitKJ/issues/153#issuecomment-2453543323, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BI22TKHAUXYAVWAV2ZK7LOTZ6ZX2DAVCNFSM6AAAAABRC7B7GOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU2DGMZSGM. You are receiving this because you authored the thread.Message ID: @.***>