kijai / ComfyUI-Marigold

Marigold depth estimation in ComfyUI
GNU General Public License v3.0
395 stars 16 forks source link

Marigold import failed diffusers after installing new custom nodes #29

Open The-Chilli opened 2 months ago

The-Chilli commented 2 months ago

Adding any other custom node that uses diffusers (pip install diffusers) breaks Marigold and fails to import.

Current work around seem to be to manually uninstall & reinstall diffusers from python_embeded & main python install (only if also required)

Disabling or uninstalling other nodes added does not fix, only diffusers reinstall will stop the import failed:

comfyui log: [2024-05-01 13:20] Traceback (most recent call last): File "C:\ComfyUi\ComfyUI\nodes.py", line 1864, in load_custom_node module_spec.loader.exec_module(module) File "", line 883, in exec_module File "", line 241, in _call_with_frames_removed File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigold__init.py", line 1, in from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigold\nodes.py", line 5, in from .marigold.model.marigold_pipeline import MarigoldPipeline File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigold\marigold\model\marigold_pipeline.py", line 9, in from diffusers import ( ImportError: cannot import name 'LCMScheduler' from 'diffusers' (C:\ComfyUi\python_embeded\lib\site-packages\diffusers\init__.py)

After reinstall, marigold will load normally with no import failed

kijai commented 2 months ago

This would only happen if some other node forces older specific version of diffusers than diffusers>=0.25.0 .

For the same reason I don't want to force a specific version as it has potential to break other stuff using diffusers. The main issue here is that the Manager only checks for the minimum version specified globally across all node requirements, so if there's a node that has lower requirement than I have specified, it will be used and mine ignored.

UnirionGames commented 2 months ago

Adding any other custom node that uses diffusers (pip install diffusers) breaks Marigold and fails to import.

Current work around seem to be to manually uninstall & reinstall diffusers from python_embeded & main python install (only if also required)

Disabling or uninstalling other nodes added does not fix, only diffusers reinstall will stop the import failed:

comfyui log: [2024-05-01 13:20] Traceback (most recent call last): File "C:\ComfyUi\ComfyUI\nodes.py", line 1864, in load_custom_node module_spec.loader.exec_module(module) File "", line 883, in exec_module File "", line 241, in _call_with_frames_removed File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigoldinit.py", line 1, in from .nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigold\nodes.py", line 5, in from .marigold.model.marigold_pipeline import MarigoldPipeline File "C:\ComfyUi\ComfyUI\custom_nodes\ComfyUI-Marigold\marigold\model\marigold_pipeline.py", line 9, in from diffusers import ( ImportError: cannot import name 'LCMScheduler' from 'diffusers' (C:\ComfyUi\python_embeded\lib\site-packages\diffusersinit.py)

After reinstall, marigold will load normally with no import failed

same here

alenknight commented 1 month ago

I'm having same issue. how do we update diffusers?

alenknight commented 1 month ago

worked. updated manually the diffusers. obviously this could break other stuff. see this issue - @kijai helped resolve prior = https://github.com/kijai/ComfyUI-Marigold/issues/28 def. worked... but just be aware OTHER stuff could now break. though if everything updated... SHOULD be ok.

shangshangdyx commented 3 weeks ago

When using: "MarigoldDepthEstimationVideo" node, an error occurred: Error occurred when executing MarigoldDepthEstimationVideo: name 'MarigoldDepthPipeline' is not defined When using: "MarigoldDepthEstimation_v2" &"MarigoldDepthEstimation_v2" node ,Error occurred when executing MarigoldModelLoader: diffusers==0.28 is required for v2 nodes

i use "python -m pip install --upgrade diffusers '' in VENV,and have tried "python -m pip install diffusers==0.28" but still not work. only "MarigoldDepthEstimation“node working.

微信图片_20240611115925 微信图片_20240611115931
shangshangdyx commented 3 weeks ago

When using: "MarigoldDepthEstimationVideo" node, an error occurred: Error occurred when executing MarigoldDepthEstimationVideo:使用“MarigoldDepthEstimationVideo”节点时,发生错误:执行MarigoldDepthEstimationVideo时出错: name 'MarigoldDepthPipeline' is not defined未定义名称“MarigoldDepthPipeline” When using: "MarigoldDepthEstimation_v2" &"MarigoldDepthEstimation_v2" node ,Error occurred when executing MarigoldModelLoader:使用“MarigoldDepthEstimation_v2”&“MarigoldDepthEstimation_v2”节点时,执行MarigoldModelLoader时发生错误: diffusers==0.28 is required for v2 nodesV2 节点需要 diffusers==0.28

i use "python -m pip install --upgrade diffusers '' in VENV,and have tried "python -m pip install diffusers==0.28"我在 VENV 中使用“python -m pip install --upgrade diffusers '”,并尝试过“python -m pip install diffusers==0.28” but still not work.但仍然不起作用。 only "MarigoldDepthEstimation“node working.只有“MarigoldDepthEstimation”节点工作。 微信图片_20240611115925 微信图片_20240611115931

i upgrade diffusers in my main python,V2 nodes working!!!but "MarigoldDepthEstimationVideo" nodes still 'MarigoldDepthPipeline' is not defined