search

kijai / ComfyUI-SUPIR

SUPIR upscaling wrapper for ComfyUI
Other
1.2k stars 66 forks source link

about the tiled quailty #105

Closed K-O-N-B closed 1 month ago

K-O-N-B commented 2 months ago

image

what can I do for fix this....?

kijai commented 2 months ago

Did you use tile stride?

K-O-N-B commented 2 months ago

tile stride

I guess no.....I even don't where is it.....

I just use the default workflow, just change the sampler to tiledrestoredpmpp2msampler.

image
kijai commented 2 months ago

tile stride

I guess no.....I even don't where is it.....

I just use the default workflow, just change the sampler to tiledrestoredpmpp2msampler.

image

Weird, in the sampler you seem to have tile stride set to tile size.. which effectively disables stride and you get the borders, stride should be half of the tile size.

K-O-N-B commented 2 months ago

help..... all the images higher then 6K will like this.

image

TiledRestoreEDMSampler is better, but still can't use.

image

bigcat88 commented 1 month ago

Can you provide a source image to test on so we can compare results?

K-O-N-B commented 1 month ago

upscale 2x and 3x pls.

ComfyUI_temp_zjcqu_00002_

bigcat88 commented 1 month ago

output00016.heic.zip

Was only able to do 2x upscaling, 64Gb of RAM is not enough to make 4608х8064 as a result. And due to GitHub limit of 10Mb I uploaded it as a heic in zip..

yushan777 commented 1 month ago

Also no problems here. I think your tile stride is too high, it should be lower than the tile size (think of it as the overlap between tiles to help blending).

Another thing is that I think SUPIR more of a detailer better-suited to photographic images (where minute details are more critical). Art styles probably don't need SUPIR and you can maybe away with other upscalers. Having said that, it is no slouch either way.

K-O-N-B commented 1 month ago

got it.