Open moguldigital opened 8 months ago
kijai
commented
8 months ago I suspect that has something to do with specific dimensions and how it tiles the image, I don't know if it's supposed to support any resolution. I was able to do 512p x 8 with tile size 1024 just now. It's always going to be much slower as it has to fix the seams too, thus the point of tiling is to save memory, not time.
kijai
commented
8 months ago Also to note, while the tiled sampling itself is working, the captioning for tiles is not implemented yet.
moguldigital
commented
8 months ago I tried with 512px starting image and 8x upscale and it also stops midway. I also tried with runpod 24gb 3090 gpu.
kijai
commented
8 months ago Can you monitor the memory use? both VRAM and RAM, does either get full? Hard to say what is the problem when it doesn't give errors, I've only tested locally with 4090 24GB, and 64GB system RAM.
rotatorotator
commented
8 months ago Also to note, while the tiled sampling itself is working, the captioning for tiles is not implemented yet.
kijai
commented
8 months ago Also to note, while the tiled sampling itself is working, the captioning for tiles is not implemented yet.
* Does this mean when using tiled sampling is activated it does the upscaling without a prompt? * What is the difference between tiled sampling and tiled vae (actually I know what tiled_vae is)
It means with tiled sampling it just uses single prompt for all tiles, I have working version in dev branch currently that can generate captions for each tile, it's just bit larger setup.
Tiled VAE only does the encoding/decoding of latents with a tiled method, it's slower but saves a ton of memory.
Tiled sampling actually samples the image in tiles, also saves memory and makes it possible to do extremely large images, but it's more challenging to condition so that each tile doesn't start to become it's own image. The controlnet SUPIR uses works very well on it's own for tiling, but your prompt has to be very generic then.
upscaling pictures with use_tiile_resampling is not working. Normal upscaling is working fine and I can do 3 times upscale on a 1024 by 1024 picture, but if I select tiile resampling and go 4 or 5 times upscaling, SUPIR works for some time and then comfyUI stops working. If I select tile resampling and select 2x on a 1024px picture then it works but takes longer than if I just upscale 2x on a 1024px picture with tile resampling. I'll attach my settings and terminal. I'm using runpod with a 20gb gpu.
