roberbike
commented
1 year ago Done.
El sáb, 27 may 2023 a las 10:10, Antonio Vanegas @.***>) escribió:
@.**** requested changes on this pull request.
Thanks @roberbike https://github.com/roberbike for your contribution. Please only do the changes of my comments. I could finish the implementation after that. Don't worries :)
In examples/gravity/readGasConcentration.cpp https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207753548 :
@@ -0,0 +1,95 @@ +/*!
Please, for the moment remove this example because it don't use the CanAirIO Sensorlib example structures. This will be to understand but maybe will be useful for write a CanAirIO example.
In src/Sensors.cpp https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207754679 :
@@ -557,8 +559,12 @@ float Sensors::getUnitValue(UNIT unit) { return pres; case ALT: return alt;
- case GAS:
- return gas;
- // case GAS:
we could rename this gas variable if it has a conflicts with the new gas object. Or why is the reason to comment it?
In src/Sensors.hpp https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207768481 :
-#define CSL_VERSION "0.5.9" -#define CSL_REVISION 366 +#define CSL_VERSION "0.5.9.1"
this is invalid, only add one more to the final number of revision and version.
More info here:
https://docs.platformio.org/en/latest/manifests/library-json/fields/version.html
In src/Sensors.hpp https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207768956 :
@@ -251,21 +259,22 @@ class Sensors {
float getAltitude();
- float getGas();
- // float getGas(); // Posible colision con DFRobot Multigas
I understand you. Maybe could be remove the gas method, or change it to real unit, a specific unit. Like, getCO2, getCO, getPM25.
In src/drivers/DFRobot_MultiGasSensor.h https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207769387 :
@@ -0,0 +1,326 @@ +/*!
We don't need this file here. It is already included in the library dependency. Please remove it.
In src/drivers/DFRobot_MultiGasSensor.cpp https://github.com/kike-canaries/canairio_sensorlib/pull/165#discussion_r1207769420 :
@@ -0,0 +1,95 @@ +/*!
We don't need this file here. It is already included in the library dependency. Please remove it.
— Reply to this email directly, view it on GitHub https://github.com/kike-canaries/canairio_sensorlib/pull/165#pullrequestreview-1447200360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7JITAWOKJUED26X4BSEMDXIGZH7ANCNFSM6AAAAAAYPMR6MY . You are receiving this because you were mentioned.Message ID: @.***>
First step to add DFRobot Multigas sensor. Many errors, in this first step. could you guide me?