search

kike-canaries / canairio_sensorlib

Particle sensor manager for multiple sensors: Honeywell, Plantower, Panasonic, Sensirion, etc. This is sensors layer of CanAirIO project too.
https://canair.io/docs/sensorlib.html
GNU General Public License v3.0
37 stars 12 forks source link

Fix sensor registration at Sensors::CO2scd30Init() and Sensors::CO2scd4xInit() #204

Closed melkati closed 6 months ago

melkati commented 6 months ago

Description

I moved the sensor registration up in Sensors::CO2scd30Init() and Sensors::CO2scd4xInit() to fix (2).

I don't see any side effects. Tested with both sensors in CO2 Gadget and looks like it's working fine.

In Sensors::CO2scd30Init() I also changed In Sensors::CO2scd30Init() to multiply toffset * 100 to convert into hundredths of a degree C to comply with Sensirion's API.

Maybe we should do the same for Sensors::sen5xInit() but I don't have one to test.

Related Issues

This is one partial fix for issue #203

Tests

I added the following tests:

I don't see any side effects. Tested with both sensors in CO2 Gadget and looks like it's working fine.