search

kikito / anim8

An animation library for LÖVE
MIT License
730 stars 88 forks source link

Add Animation:getDuration() #18

Closed WetDesertRock closed 8 years ago

WetDesertRock commented 8 years ago

Just totals Animations.durations. I added it for my LD game, figured it is a nice function consider for the official lib.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.8%) to 97.495% when pulling ce829dc223030353c7994d41547a080979eb4c79 on WetDesertRock:patch-1 into 539cc26fee6517a37448ee70ee830e56921137be on kikito:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 98.109% when pulling c0d535a18483b9b467bbe794268573ca7f25cff1 on WetDesertRock:patch-1 into 539cc26fee6517a37448ee70ee830e56921137be on kikito:master.

kikito commented 8 years ago

I have decided to not merge this. I think if someone needs to get the total duration they can do anim.totalDuration directly, without "wrapping it in a method".

That said, thanks a lot for sending this pull request, and I hope this won't discourage you from sending me others in the future.