search

kikito / love-loader

Threaded resource loading for LÖVE
http://love2d.org
MIT License
131 stars 16 forks source link

newImageData() change to newImageData(newFileData) #7

Closed pablomayobre closed 10 years ago

pablomayobre commented 10 years ago

I noticed a high improvement in speed loading imaged this way.

kikito commented 10 years ago

I am a bit surprised that this makes things faster. If anything, it should make them slower IMHO.

I don't doubt you, but can you tell me how you tested the loading speed difference, so I can replicate?

pablomayobre commented 10 years ago

I have a code loading 22 1024x1024 images so it takes a while in my slow computer. My idea was loading images from the AppData folder so I edited the love-loader code to load images with filesystem, but I left the images in the program folder. When running the code it loaded faster. Can't really explain it either but i'll try replicating it with a love file and upload it here.

pablomayobre commented 10 years ago

Well I compared them loading 52 images side by side and they loaded at the same speed, there is no improvement. I think I was wrong.

This method is not faster nor slower, this code would be used in other applications were loading images from the AppData folder is necesary, also I wouldn't recommend this code for security purposes (you don't want the images in your game being changed by some guy that placed his images in the wrong directory)

kikito commented 10 years ago

Ok then :).

Thanks for trying to improve the library anyway. Let me know what you accomplish!

I will close this now.