Closed ghost closed 8 years ago
I have not forgotten about this (hectic weekend). I still have to give it a more thorough review.
Thanks for the heads-up. Take your time, there's no hurry. Meanwhile I'll push my rebased version.
I finally was able to review this (sorry about the delay).
I made a small change: update
returns self
. This way, you can chain commands:
local x = md5.new():update('foo'):update('bar'):finish()
I will now create a changelog and release md5 1.1.0
EDIT: updated and uploaded to Luarocks!
Implements #8.
Tested with a 47 Gb file, with LuaJIT only, using the following program:
(took 3+ hours; the result was compared to that of
md5sum
which took ~8 minutes). The updates were sent with random lengths to exercise different buffer fills.Couldn't test with Lua as it refused to open the file.
It is based on the commits of PR #9, so they are included too. I can rebase if necessary.