Closed ExtReMLapin closed 2 years ago
Hello If i'm not wrong your changes introduce "ffi" as mandatory required. But md5.lua is supposed to be run with or without "ffi" : PUC/Rio LUA don't have "ffi". Please consider the case of "ffi" not available : fallback to a code without "ffi". Regards,
yes, my bad, I forgot to push the very last version of my edits, it's now fixed
As a performance PoV it would be probably better to define the function inside the condition and not have the condition inside the function, but whatever.
200% perf boost from 880eaf24c408e2f1ec6102f7d09bdef5ad821069 to e5d472f8d5fc521cdded700686f3a148bc3bdd14
This is really good, I'd approve this change!
There is a luajit only compatible md5 here, which is only if using the optimizations I pushed on it, also faster than this version with the luajit optimizations (28% faster)
Thanks for this, I have merged it. Apologies for the time it took me to do it.
43350% performance boost on lei2str
Didn't benchmark str2lei but it's also faster
Edit:
after all the optimizations done here, it's a