kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
23 stars 8 forks source link

[Request] Show base colour from NBT (as if dyed)? #1

Closed sisby-folk closed 1 year ago

sisby-folk commented 1 year ago

Not to blatantly blow your scope right after you release a really cool mod that we're definitely putting in our first 1.20 pack, but it occurs to us that dye color, like trim, is also just a random bit of NBT stapled onto an item (like {display:{color:16007844}} if i'm not mistaken)

Would it be possible to have the client mod make this show on the base colour of the elytra, like trimmed leather armor?

There are other dyable elytra mods, but the ones I can find are mixed side and more invasive than the client + datapack solution which seems really cool (and i'd be unsure they'd be compatible)

Cool mod!

kikugie commented 1 year ago

Dying elytra turned out to be quite easy, but the problem is dyeable recipes are not datapack configurable. 2023-04-19_18 20 29
Closest idea I have is a recipe of elytra + dyed leather chestplate, but im not sure if datapacks can be configured to copy nbt from one of the ingredients. Most of it is hardcoded into the game.

sisby-folk commented 1 year ago

That already looks like a great addition to the client mod! (/give commands would work already)

In terms of server side, I think making something dyable is in the realm of a server mod rather than a server datapack - mods like QDRON and Nbt-Crafting could make it datapackable, but I think that's far more complex then just mixing in to make ElytraItem implement DyableItem which I think can run with vanilla clients, and does all the recipe stuff for you - worth a test.

kikugie commented 1 year ago

2023-04-29_13 19 08 Updated in the last commit with better texturing

kikugie commented 1 year ago

Released in https://modrinth.com/mod/elytra-trims/version/1.1.0+1.19.4 👍

sisby-folk commented 1 year ago

Looking really good! excited to play around with it.

javaw_g0T7SdQkpi

https://user-images.githubusercontent.com/55819817/235333462-77711b8c-5262-4585-bb12-7a0a07ae07bc.mp4