search

kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
23 stars 8 forks source link

Incompatibility with Memory Leak Fix #24

Closed hound22 closed 9 months ago

hound22 commented 10 months ago

Bug description

The game was crashing during startup and I approached quilt support, who pointed out that this was because elytra trims might be incompatible with 0.5.0+ and they were right, removing this mitigated the crashing.

Steps to reproduce

  1. Have sodium 0.5.0+ (I used sodium 0.5.2) and elytra trims version 1.3.0 mods with quilt loader version 0.20.0 and qfapi version 7.1.2+0.87.0.
  2. Start minecraft.

This will fail to start and crashes without showing why it caused an error from quilt loader.

Expected behavior

No response

Actual behavior

No response

Relevant logs

The log file didn't generate it seems, but here is the relevant crash report that the quilt support team narrowed down the issue to elytra trims with: new crash.txt

Minecraft version

1.20.1

Elytra Trims version

1.3.0

Other information

No response

Check list

kikugie commented 10 months ago

This error is unrelated to Elytra Trims, its caused by Memory Leak Fix mod

kikugie commented 10 months ago

Quilt has some problems with Mixin Extras, which sometimes appear, sometimes not. So it might be the case

hound22 commented 10 months ago

Oh! I'm sorry for opening this issue in that case. It is weird that I was able to successfully load in after removing elytra trims as well then, could this be a mod disparity/conflict perhaps?

endigma commented 10 months ago

Confirming this only occurs when both Elytra Trims and Memory leak fix are enabled. This is on fabric. Disabling memory leak fix to "fix" the problem results in: image

kikugie commented 10 months ago

https://github.com/fxmorin/MemoryLeakFix/pull/138 this is Memory Leak Fix issue, which is already pushed and should be up in the next update

endigma commented 10 months ago

Removing memory leak fix just blends the text, I don't understand why you're ignoring this?

kikugie commented 10 months ago

Your issue is caused by an incompatibility with some other mod, please don't bring it into a discussion about Memory Leak Fix, that has been resolved. Although, that kind of error is probably fixed in https://github.com/kikugie/elytra-trims/actions/runs/6000651138 . If it remains with that patch, create a separate report for it.