kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
32 stars 10 forks source link

[Bug]: Incompatibility with First-Person Model #58

Closed peow closed 6 months ago

peow commented 6 months ago

Mod loader

Fabric

Minecraft version

1.20.1

Mod version

3.1.5

Affected mods

Bug description

when using the Elytra Trims together with the First-Person Model, when holding an Elytra in your hand the head of your skin disappears

2024-05-12_21 52 39

2024-05-12_21 52 42

since Minecraft doesn't refresh a model while you're viewing the model, you need to exit F5 and come back to see that your head is gone


First-Person Model usually disables the rendering of some part of the body when it detects that this will hinder the first-person view, I imagine that something in the Elytra Trims has made First-Person Model think that the Elytra in the hand would be equipped in the head or something similar, idk

the problem stops when you press F6 to disable First-Person Model


I'm using Fabric 1.20.1, First-Person Model 2.3.4 2024-05-12_22 01 54

mod link: https://modrinth.com/mod/first-person-model


if is possible to fix this pls make an update to Fabric 1.20.1, thanks

Steps to reproduce

  1. Install Elytra Trim (+dependencies)
  2. Install First-Person Model
  3. Select a Elytra in the hotbar and press F5

Relevant logs

I don't think the log is necessary, but in case I'm wrong: https://mclo.gs/KkaRM89

kikugie commented 6 months ago

Congratulations on discovering a hidden bug I totally wasn't aware of, but on a serious note i don't know. It also can make your head reappear in 3rd person just as magically and the mods don't have any code interacting with each other.
So I'll leave this open for now, and as a temp fix you can disable the elytra model in the mod config.

peow commented 6 months ago

i will show the issue to the First-Person model dev

kikugie commented 6 months ago

I've found a solution that should fix both issues, but it definitely needs some tinkering with the model positioning: 2024-05-13_22 47 09

kikugie commented 6 months ago

too sticker

peow commented 6 months ago

xd, good luck

kikugie commented 6 months ago

The fixes are done. I want to see if I can check off some other known bugs off the list and test other mc versions before publishing.
Here's the current build of the mod, so you don't have to wait: elytratrims-fabric-3.1.6-bugfix+1.20.1.zip (extract the file because gh doesn't allow .jar)

peow commented 6 months ago

one question: is it possible to prevent the Elytra from overlapping with the hotbar frame?

image image

kikugie commented 6 months ago

I tweaked it a bit for the next update image

peow commented 6 months ago

show me the hotbar pls

kikugie commented 6 months ago

image

peow commented 6 months ago

epic

peow commented 6 months ago

First-Person Model mentioned u on his discord server, just so you know

kikugie commented 6 months ago

I am aware lol