kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
32 stars 10 forks source link

[Bug]: Elytra trims with Extensions and Geode+ do not render #61

Closed Rymka69 closed 6 months ago

Rymka69 commented 6 months ago

Mod loader

Fabric

Minecraft version

1.20.1

Mod version

3.1.8 (Extensions 2.1.0)

Affected mods

Bug description

Elytra Trims extensions and Geode+ don't work that well together. What I figured out, Is that If you use non-Geode+ provided trim patern and a Geode+ trim material, the result does not render. When applied the Item and Elytra in 3rd person renders without a trim, even though it is in the description of the item. image

In the screenshot, the trim patters (in inventory space, not hotbar) combined with any of the three materials of Geode+ in the hotbar give this preview. Only using Geode+ patterns works with Geode+ materials (Geode+ patterns also work with vanilla materials).

Mods used while testing this: Fabric Loader 0.15.11 Fabric API 0.92.2 Elytra Trims 3.1.8 Elytra Trims Extensions 2.1.0 Geode+ 1.2.4 MoreArmorTrims 1.2.0 Fabric Language Kotlin 1.11.0

Steps to reproduce

  1. Install Elytra Trims, Elytra Trims Extensions and Geode+ (and dependencies)
  2. Get Smithing table, Pink Topaz, Silece Smithing Template and Elytra
  3. Combine them, see the result without any pattern displayed

Relevant logs

No response

kikugie commented 6 months ago

Elytra Trims is configured to copy all trims specifications added by mods and resourcepacks. This issue is caused by Geode+ itself, as seen on the image. If the Geode+ author won't fix the issue, you can use All The Trims to patch the missing textures.

image