search

kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
23 stars 8 forks source link

[Bug]: Trims and patterns don't match the shape of custom elytras #63

Open Daniel99j2 opened 3 weeks ago

Daniel99j2 commented 3 weeks ago

Mod loader

Fabric

Minecraft version

1.20.4

Mod version

3.1.8

Affected mods

Bug description

Sodium is not installed. Due to the 15th anniversary cape not conforming to the normal shape, any parts not on the main texture are rendered with water and clouds "above" them. This is easily seen with bug #62 (note in the missing texture one, the dark pixels are the black of the texture) 2024-06-03_17 02 53 2024-06-03_17 02 57

Trims also hang off the cape with the new cape. (normally the only way to get bug # 1 without the easter egg) Trims off cape: ezgif-6-f2d65be47a

Steps to reproduce

  1. Equip the 15th anniversary cape
  2. Trim an elytra with silence (others may also have the bug)
  3. Note that when switching from normal -> silence there are extra pixels that show up
  4. Go to a water pool
  5. The extra pixels will look transparent

Relevant logs

No response

kikugie commented 3 weeks ago

This is known (and more noticable with custom elytras with their own shapes). In technical terms, Elytra Trims samples the default elytra texture you have to crop banners and trims. Making it mask for all elytras would multiply the amount of generated textures and cause performance issues. And in addition to that, capes can possibly have unregistered shapes.
This will require a big rewrite of the texture handling system, which is a lot of work, so I humbly ask to cope with having 2 pixels for now.

Daniel99j2 commented 3 weeks ago

👍