search

kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
32 stars 10 forks source link

[Bug]: Wrong Posed Model View #65

Closed Fyoncle closed 5 months ago

Fyoncle commented 5 months ago

Mod loader

Fabric

Minecraft version

1.20.1

Mod version

3.2.0

Affected mods

Bug description

image Elytra models looking weird when first placed on a smithing table or taken to hand, not sure if this because of Elytra Trims mod since i didn't try it with only Elytra Trims mod, i am using Elysium Days 3.5.0 Modpack

Steps to reproduce

  1. Install Latest Release Of Elysium Days
  2. Update Elytra Trims To 3.2.0
  3. Take a Elytra from Creative (see model wrong for few seconds when holding then it fixes itself automatically)
  4. Put in a smithing table and put your trim and stuff
  5. See the elytra shape being all plain instead of elytra opens wings image image Then a few seconds later it fixes itself

Relevant logs

https://mclo.gs/47haexn

kikugie commented 5 months ago

It doesn't happen in Elytra Trims on itself, so it's a mod compatibility issue. I can't test it by manually copying each of your 400 mods, so please narrow it down.

Fyoncle commented 5 months ago

It doesn't happen in Elytra Trims on itself, so it's a mod compatibility issue. I can't test it by manually copying each of your 400 mods, so please narrow it down.

Oh... :(

Fyoncle commented 5 months ago

Okay then, ill binary search and return back.

Fyoncle commented 5 months ago

So, it only happens normal worlds i guess, but when you open a void world, it loads the elytra thing so fast that its impossible to see any difference or the glitch, i tried some things but didn't been able to fix it.

kikugie commented 5 months ago

Referencing https://github.com/kikugie/elytra-trims/issues/66#issuecomment-2170545601 I can reproduce it with Fresh Moves, in which case it's on the resourcepack's side. Elytra Trims doesn't change how elytra is animated. For the smithing table it just equips the item on the armor stand.

Fyoncle commented 5 months ago

Referencing #66 (comment) I can reproduce it with Fresh Moves, in which case it's on the resourcepack's side. Elytra Trims doesn't change how elytra is animated. For the smithing table it just equips the item on the armor stand.

Eh i think its more likely EMF ETF's problem then, but ill let the Fresh Moves devs know too.

kikugie commented 5 months ago

I suppose the latter. It doesnt happen without the Fresh Moves pack. And in case, fortunately this fixes itself quickly.

Fyoncle commented 5 months ago

I suppose the latter. It doesnt happen without the Fresh Moves pack. And in case, fortunately this fixes itself quickly.

But Fresh Moves uses the possibilities of EMF ETF, not only Fresh Moves but every other pack that activates EMF ETF will also cause this, so i think perfect place to report this is traben!

kikugie commented 5 months ago

I guess won't hurt. But it's the Player Moves pack controlling the elytra position

Fyoncle commented 5 months ago

I guess won't hurt. But it's the Player Moves pack controlling the elytra position

Well reported to both sides xD lets see who fixes the issue first :)

Fyoncle commented 5 months ago

Also how the hell did you do the easter egg? i checked source code for infinite whiles and tried infinite combinations, how the hell to make the easter egg work lol, i saw it bad apple easter egg

kikugie commented 5 months ago

What infinite whiles? Also the bad apple one just has an animated texture.

Fyoncle commented 5 months ago

What infinite whiles? Also the bad apple one just has an animated texture.

Infinite hours basically lmao, but how to activate bad apple inside the game?

kikugie commented 5 months ago

You literally combine it with a bad and an apple.

Fyoncle commented 5 months ago

You literally combine it with a bad and an apple.

A "bad"...? what is a bad.

kikugie commented 5 months ago

Find out :P

Fyoncle commented 5 months ago

Find out :P

Evil :(

Fyoncle commented 5 months ago

Find out :P

Combine in what exactly... smithing table? Atleast give a hint of that!

kikugie commented 5 months ago

Naturally crafting. If you're really desperate, look through the source code, but that kinda ruins the point of it being an easter egg.

Fyoncle commented 5 months ago

Naturally crafting. If you're really desperate, look through the source code, but that kinda ruins the point of it being an easter egg.

I did check the whole source code, nothing else there :v

kikugie commented 5 months ago

The recipe is hardcoded so iono bad reading skills

Fyoncle commented 5 months ago

The recipe is hardcoded so iono bad reading skills

:c

kikugie commented 5 months ago

||https://github.com/kikugie/elytra-trims/blob/kotlin/src/main/kotlin/dev/kikugie/elytratrims/common/recipe/ETAnimationRecipe.kt ||

Fyoncle commented 5 months ago

||https://github.com/kikugie/elytra-trims/blob/kotlin/src/main/kotlin/dev/kikugie/elytratrims/common/recipe/ETAnimationRecipe.kt ||

image Um... isn't it meant to be animated...?

kikugie commented 5 months ago

400 mods be like

Fyoncle commented 5 months ago

400 mods be like

:(

Traben-0 commented 5 months ago

If its caused by fresh moves animations, then there is nothing that can be done really :/

though you could variate the model by the entity type wearing them and ensure the default non-animated model loads for armor stands

kikugie commented 5 months ago

Same as #66