search

kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
23 stars 8 forks source link

Incompatible with armor trim materials from the Cinderscapes mod #7

Closed Diego13303 closed 11 months ago

Diego13303 commented 12 months ago

Description

Trying to trim Elytras with ores from the mod Cinderscapes shows a missing texture in the Smithing Table and no difference from an untrimmed Elytra in-game image image

To Reproduce

Steps to reproduce the behavior:

  1. Put an Elytra and an armor trim in a Smithing Table
  2. Attempt to use Rose Quartz, Smoky Quartz or Sulfur Quartz from Cinderscapes as the trimming material
  3. Preview on Smithing Table displays as missing texture
  4. Grab the trimming result

What you expect to see: The Elytra with the correct trimming

What actually happens: I get an Elytra with tooltips indicating it´s been trimmed, but visually it looks the samed as an untrimmed one

Environment

Describe the environment to reproduce this bug:

kikugie commented 12 months ago

It doesn't restrict trim patterns to ones with available textures to allow resourcepack support (Which Elytra Trims Extensions relies on). And to show that it intentionally has magenta/black texture in the smithing table, but none in the world to not ruin the look.

Compatibility won't be added to the main mod, but I'll work on adding it to the extensions.

Diego13303 commented 12 months ago

Oh I see! So is Elytra Trims Extensions just Resource packs then?

kikugie commented 12 months ago

Yea, its a bundle of resourcepacks, with an idea that it would be more convenient to download one mod than a bunch of separate resourcepacks

Diego13303 commented 12 months ago

I see! I´ll wait for it to be updated to add support for Cinderscapes then. Thank you so much for the quick reponse!

kikugie commented 11 months ago

Cinderscapes only adds new materials, so its the same issue as #10.
1.1.10-beta fixes the broader issue, providing support for any new material. Its still experimental, so please create a new issue report for it if needed.