kikugie / elytra-trims

Lightweight and customizable support for trimmable elytras
https://modrinth.com/mod/elytra-trims
GNU Lesser General Public License v3.0
32 stars 10 forks source link

[Bug]: remaining incompatibilities with Butterfly Elytra from the Clutter mod #71

Closed peow closed 4 months ago

peow commented 4 months ago

Mod loader

Fabric

Minecraft version

1.20.1

Mod version

3.4.0

Affected mods

Bug description

the trimmed Butterfly Elytras (fixed in the last update) are interesting, but the mod needs to block Butterfly Elytras from being colored and banners from being added to them

because when you dye it, it loses all its texture, and when you put the banner on it, the banner also covers all its texture



besides, as the Butterfly Elytra is smaller than the Vanilla Elytra, there are some visual problems, for example the cloud renders on top of Butterfly Elytra with banner


by preventing the Butterfly Elytra from being colored and applying banners to it, these problems would be solved

Steps to reproduce

1 - Install Elytra Trims 2 - Install Clutter 3 - modify a Butterfly Elytra (coloring/adding banner)

Relevant logs

No response

kikugie commented 4 months ago

Colored textures use the base elytra model as the reference, which is why custom shaped elytras look wrong.
I won't disable any features for any mod by design, so if you don't like how that looks - don't apply dyes and banners yourself.

Apart from that, the issue is of the same nature as #63, so I'll mark it as duplicate.

peow commented 4 months ago

don't apply dyes and banners yourself. I'm imagining the possibility of some user trying to modify a modded Elytra and realizing that it didn't work, then he comes to bother you asking why it's not working

if you don't want to disable any feature for any mod, at least allow it to be possible to remove the modifications by using the cauldron with water, currently only the Vanilla Elytra can be "cleaned", modded Elytras cannot.

https://github.com/kikugie/elytra-trims/assets/105888751/2a9496df-a135-409f-a984-4bba6633ac27

testing with Clutter and BetterEnd

kikugie commented 4 months ago

Added cauldron cleaning in 3.4.1