search

kilbd / nova-rust

A Rust extension for the Nova text editor, using the Rust Analyzer language server.
MIT License
29 stars 5 forks source link

[FEAT] Adding spell-check to strings and comments #28

Closed illegalhex closed 2 years ago

illegalhex commented 2 years ago

Is your feature request related to a problem? Please describe. Currently strings and comments do not have spell check enable for their scopes, and for me that is a problem.

Describe the solution you'd like Have the <spell-check="true"> tag applied to the rust.comment.single, rust.comment.multiline, and rust.string.docstring scopes inside the comments collection as well as to the rust.string, rust.string.raw, rust.string.raw.quote, and rust.string.byte scopes inside the values collection.

Describe alternatives you've considered I've currently modified the plugin for localy for this change, but I'd prefer not to continue to have a modified version of the plugin.

Additional context If this is something you want in the plugin, I'll submit a PR with the change.

kilbd commented 2 years ago

I definitely overlooked spell check, so thank you for bringing up this issue and helping other users find their typos!

I'm more than happy to add this change to the bundle of changes I'm currently working on since you wrote a very clear issue description. I'm equally happy to approve a PR from you if submitting one makes you happy. Thanks!