kilbot / WooCommerce-POS

:bangbang: All development now at https://github.com/wcpos.
http://wcpos.com
GNU General Public License v3.0
353 stars 125 forks source link

POS Only products are not filtered out on product tag and attribute pages. #143

Closed Goosse closed 7 years ago

Goosse commented 7 years ago

Products that are marked as "POS Only" still show up on the website on product tag (eg. www.example.com/product-tag/sample-tag/ and attribute pages (eg. www.example.com/shop/?filter_materials=steel)

kilbot commented 7 years ago

Please see the docs on Catalog Visibility.

Goosse commented 7 years ago

oh, thanks. Sorry about that.

kilbot commented 7 years ago

No problem, sorry for the one line reply. I'm currently busy with 0.5 to have it out before Christmas.

This is a 'gotcha' for many POS Only users. WooCommerce has it's own logic for hiding products from the catalogs. I don't want to reproduce or conflict with that logic in any way and I like having the flexibility of all configurations. However, there needs to be a note added to the Edit Products page which links to the docs. I will slip this into 0.5.

Goosse commented 7 years ago

Yes, the way you handled it makes perfect sense, given what woocommerce already does. Makes me wonder though. Are there any woocommerce filters to add a _visibility option? So that “pos_only” would simply be added to woocommerce’s visibility dropdown. Just something that crossed my mind, but haven’t looked at it.

On Nov 28, 2016, at 8:42 PM, Paul Kilmurray notifications@github.com wrote:

No problem, sorry for the one line reply. I'm currently busy with 0.5 to have it out before Christmas.

This is a 'gotcha' for many POS Only users. WooCommerce has it's own logic for hiding products from the catalogs. I don't want to reproduce or conflict with that logic in any way and I like having the flexibility of all configurations. However, there needs to be a note added to the Edit Products page which links to the docs. I will slip this into 0.5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kilbot/WooCommerce-POS/issues/143#issuecomment-263460493, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVk_x_QMBQM9ch1BbcNQprmAvZ06KSiks5rC5EEgaJpZM4K94Ap.