search

kilianc / base-golang

0 stars 1 forks source link

Discussion: why removed gomonkey? #2

Closed xhd2015 closed 3 months ago

xhd2015 commented 3 months ago

Hi @kilianc , I see in your last commit, you dropped the gomonkey dependency. Is there any specific reason you don't want to use it?

kilianc commented 3 months ago

@xhd2015 sorry just seeing this. The main reason why I removed it is because it didn't work consistently. I am happy to revisit the decision if the issues are addressed!

xhd2015 commented 3 months ago

@xhd2015 sorry just seeing this. The main reason why I removed it is because it didn't work consistently. I am happy to revisit the decision if the issues are addressed!

Huh so I know, that's also the reason I guessed.

I'll later create a PR using another stable solution( specifically the one I created: https://github.com/xhd2015/xgo), hope you can consider that. Thanks for replying.