search

kiliankoe / MensaDresden

🌯 See what's for lunch at Dresden's canteens
https://apps.apple.com/us/app/mensa-dresden/id1481891701?ls=1
MIT License
27 stars 6 forks source link

Persistence for canteens and Autoload transactions #64

Open kiliankoe opened 4 years ago

kiliankoe commented 4 years ago

Save both of these in CoreData. It would probably also make sense to try and be smart about fetching transactions trying to get as much old data as possible and then only fetching new stuff.

welljsjs commented 3 years ago

Hiya, not sure if you're still working on this project or if you're still interested in active dev but this would deffo be a really handy feature! I've just tried to put in my card details but it won't show the transactions on the emeal page. Do you think there's any chance you can look into this in case you got a minute spare or two? I'd even help out if you need help, just a bit busy atm But really cool app btw, nice job!!

Edit: whoops looking at this issue again I think my description does not quite match but could be related anyways? And yeah looks feasible, would you accept PRs? Might have a closer look when I get the time - is there a CLA I'd have to sign?

kiliankoe commented 3 years ago

Hi @welljsjs, thanks for checking by!

I'm not spending too much time on further development of this app currently, but there's definitely still quite a bit to do. I'm hoping to get to some if not most of that soon.

I'd love to have a look at why no transactions are showing up for you at all. Please be aware though that transactions older than 90 days are no longer accessible and new ones can take several hours to show up. The app unfortunately can't influence both of these things.

This project is of course very much open to any contributions and I'd be very glad to merge PRs that improve the app 😊 And no, there's no CLA to sign, you just have to be ok with your contributions to be licensed under the MIT license with the rest of the app's source.

welljsjs commented 3 years ago

Okie cool!

So after having put in my card details I'm getting an "unexpected date format 28.10.2020 13:26" which originates here

I'll have a dive-in once I got a bit more time, it's definitely worth supporting this app.

kiliankoe commented 3 years ago

Huh interesting, I wonder if the StuWe changed something there. I can't really check at the moment, since I have no current transactions on my Emeal card. If you can experiment a bit, that would be great 😊

welljsjs commented 3 years ago

Weird one but seems to have been related to the 24-hour-clock setting on iOS (I had mine set to 12 hour). See the PR for more details: https://github.com/kiliankoe/EmealKit/pull/18

kiliankoe commented 3 years ago

I've just pushed a new build with the fix in EmealKit into review. Thanks again! 😊

Edit: It's online 👍