kilic / bls12-381

High-speed BLS12-381 implementation in Go
Apache License 2.0
124 stars 47 forks source link

Wrong wnaf implementation #41

Open kamel78 opened 11 months ago

kamel78 commented 11 months ago

Sorry bu i think there is a big problem in this code !

The wNaf is incorrectly implemented since the size of the resulting representation (according to the code) is the same ad the size in bits of the nitial binary representation. Hence, the glv multiplication (and of course the wNaf points multiplication) are not optimized and in contrast mush slower than naive binary approach. In addition, if the goal is secure "constante" implementation, this is also not meet because of the test inside the loop (if i=0..). According to which paper you have implement this?

Regards