kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code
MIT License
3.2k stars 202 forks source link

Hyphen ligatures create overlap with other caracters #111

Closed vorban closed 4 years ago

vorban commented 4 years ago

Expected behavious : monospace font, standard spacing and character width. No overlap

What I get : image As you can see, the " caracter overlap with the 0 (it is a double-quote).

I have done some testing, this happens with double hyphen -- and simple arrow ->. Writing several arrows or double hyphen in a row, separated by spaces, will eventually provoque overlap of entire words : image

This will not happen in every code context... String litterals produce this effect all the time, I've seen it inside braces. I don't know if there's somewhere else it can happen.

I use vscode on linux.

kiliman commented 4 years ago

Have you tried this with Fira Code?

Also which font weight are you using? ScreenSmart or regular?

kiliman commented 4 years ago

This is SSm Book on Mac.

image

image

kufii commented 4 years ago

I'm getting this issue too using the non-ssm version on windows

kiliman commented 4 years ago

Windows 10.

ScreenSmart image

Non-ScreenSmart image

Not sure if it's a context thing.

Can one of you paste the actual text that is having the issue (also, let me know what language that VS Code is using (lower right).

image

kufii commented 4 years ago

I have the exact same settings as the 2nd one. Interestingly when the text is highlighted it displays correctly. language is JavaScript snippet that messes up let x = '--> --> --> -->'

vorban commented 4 years ago

image This is PHP

fontFamily : operator mono ssm lig book
fontLigatures: true
fontSize: 16
fontWeight: 300

If I am not specifying ssm, in the font family, vscode doesn't find it and fallback to default font.

kufii commented 4 years ago

ok, found out that with editor.renderWhitespace: 'all' it displays correctly

kiliman commented 4 years ago

That is super weird. It's working fine for me. Have you rebuilt the fonts using the latest version?

I even tested with editor.renderWhitespace: 'none' image

Send me your email address to kiliman@gmail.com so we can troubleshoot.

vorban commented 4 years ago

image @kufii not working with your fix

kufii commented 4 years ago

I'll try rebuilding my font and getting back to you

vorban commented 4 years ago

Me too, It's possible I messed up something

kufii commented 4 years ago

ok yeah rebuilding fixed things, don't know why that happened the first time

vorban commented 4 years ago

So I rebuilt everything from a clean version, which does not have SSm files, and it produced the Light and Light Italic versions only, but they work as expected. I suppose I had renamed files as SSm for some reason, and that caused the issue as they really weren't SSm. Thanks for the support !

kiliman commented 4 years ago

If you originally built the v1.0 fonts, those included Operator Mono Book in the ./build folder. Unfortunately v2.0 doesn't include Book, just Light. The build process didn't clean out the ./build folder so the Book font was still there from the old build. I can see how you could have been confused.

I'll try and get the Book version done this weekend. Thanks for your patience and troubleshooting this issue.

kiliman commented 4 years ago

I've added Operator Mono Book in v2.2.5. Check it out and let me know if you have any issues.

MrGabigoo commented 4 years ago

@kiliman I was having the same issue and your update fixed it ! Thank you !

vorban commented 4 years ago

It works like a charm. Thank you !