search

kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code
MIT License
3.2k stars 202 forks source link

add less_hyphen_greater ligature #115

Closed CandySunPlus closed 4 years ago

CandySunPlus commented 4 years ago

add less_hyphen_greater ligature

kiliman commented 4 years ago

Hi @CandySunPlus. Thanks for the PR, but may I ask how you created this?

CandySunPlus commented 4 years ago

I just add less_hyphen_greater.liga with glyphs based my ssm font and use extract.sh to generate the xml files

mskelton commented 4 years ago

This is a lot of file changes. Can you remove all the changes that aren't required (i.e. trailing newline added to a bunch of the files).

kiliman commented 4 years ago

This looks really nice, however, I need you to update the actual source Glyphs file instead of updating the generated fonts. In Glyphs, we use components (existing glyphs) to build up the ligature.

Here is your ligature composed of one path image

Using components (less and greater are existing glyphs, we add hyphen, decompose and stretch). We overlap and Glyphs will remove the overlap during export. Also notice that I made the horizontal hint the width of the actual ligature. image

By using existing components, it simplifies the generated font, ensuring proper hinting, etc. Also when generating the italic ligature, you can simply copy the glyph to the italic font, and Glyphs will use the italic version of the component automatically. The only thing you would need to do is select any existing paths and skew them 11 degrees.

image

I will add you to the private operator-mono-lig-source repo. Unfortunately I'm going to have to ask you to recreate your ligature in the source Glyphs file. Commit your changes and I will extract and push the ligatures out.

Thanks for your help.

CandySunPlus commented 4 years ago

where is the operator-mono-lig-source repo

kiliman commented 4 years ago

It's a private repo. I sent you an invite. You should have received an email.

CandySunPlus commented 4 years ago

It's a private repo. I sent you an invite. You should have received an email.

I have a problem with my mailbox. Can you re-initiate the invitation?

kiliman commented 4 years ago

Here's the link.

https://github.com/kiliman/operator-mono-lig-source/invitations