search

kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code
MIT License
3.2k stars 202 forks source link

Italics ligatures dont work in actually version but works in a older version #157

Closed COD3BREAK3R closed 3 years ago

COD3BREAK3R commented 3 years ago

I refer to the issue in the next comment: https://github.com/kiliman/operator-mono-lig/issues/155#issuecomment-723184255

I also add that it is not the editor's problem because when testing the sources in the system preview there are also problems with ligatures.

Captura de pantalla (102)

Captura de pantalla (103)

I hope this I hope this problem will be fixed and I also wish that the www ligature was included in the other variations of the font, and please, include Medium and Bold italics for no SSm fonts, in a older version exists but not in the actually:

Captura de pantalla (104)

Thanks

kiliman commented 3 years ago

Yeah, the italic version don't work all the time. Not sure why since it is built the same way. I'm working on a new method to generate the fonts that hopefully will resolve the issue.

As for the other versions of the non-SSm fonts, the main issue is lack of free time to generate the ligatures. Each font weight has to be individually updated for the 40+ ligatures. It's definitely on my TODO list.

Thanks for your patience.

kiliman commented 3 years ago

Finally got the italics to work properly. Turns out that the fonttools program allows you to import feature (.fea) files which have all the instructions on how to generate the substitution tables. No need to build my own.

This fix is in the v2.4 release https://github.com/kiliman/operator-mono-lig/releases/tag/v2.4.0

kufii commented 3 years ago

@kiliman it works! very exciting since this hasn't working since I first started using operator-mono-lig. Great job!

COD3BREAK3R commented 3 years ago

Finally got the italics to work properly. Turns out that the fonttools program allows you to import feature (.fea) files which have all the instructions on how to generate the substitution tables. No need to build my own.

This fix is in the v2.4 release https://github.com/kiliman/operator-mono-lig/releases/tag/v2.4.0

Ligatures italics work in Windows but not in VS Code, some idea for what reason not working in VS Code?

Captura de pantalla (110)

code

kiliman commented 3 years ago

Hmm... not sure why it's not working for you in VS Code. All the italic ligatures show properly for me on Windows.

Did you uninstall and reinstall the font? What is your VS Code font settings.

image

COD3BREAK3R commented 3 years ago

The ligatures already work correctly, it was yesterday that I uninstalled them, then today after turning on the computer I run the build.bat file and installed the fonts again and they already work. Thanks for creating this project

Hmm... not sure why it's not working for you in VS Code. All the italic ligatures show properly for me on Windows.

Did you uninstall and reinstall the font? What is your VS Code font settings.

image