Ligatures Not Working - Githubissues

kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code

MIT License

3.2k stars 202 forks source link

Ligatures Not Working #166

Closed TheBotlyNoob closed 3 years ago

TheBotlyNoob commented 3 years ago

And my font family

TheBotlyNoob commented 3 years ago

Now noticing it didn't build medium, or bold, and medium SSm breaks everything

kiliman commented 3 years ago

I have a feeling that your SSm versions are not Mono.

Unfortunately we only have Book and Light for the non-SSm versions.

TheBotlyNoob commented 3 years ago

Why doesn't book work?

kiliman commented 3 years ago

Which OS are you using?

Use editor.fontWeight to adjust weight instead of including in font family.

"editor.fontFamily": "Operator Mono Lig",
"editor.fontLigatures": true,
"editor.fontWeight": "400",

Value	Common weight name
100	Thin (Hairline)
200	Extra Light (Ultra Light)
300	Light
400	Normal (Regular)
500	Medium
600	Semi Bold (Demi Bold)
700	Bold
800	Extra Bold (Ultra Bold)
900	Black (Heavy)
950	Extra Black (Ultra Black)

TheBotlyNoob commented 3 years ago

My OS is Windows 10, and the font Operator Mono Lig doesn't seem to exist

kiliman commented 3 years ago

Did you install the fonts?

TheBotlyNoob commented 3 years ago

hmmm, Operator Mono Lig, does exist, and works! but, it looks very weird

kiliman commented 3 years ago

What's your font size? Some of these ligatures (especially the triple bar one) try to render thin evenly spaced lines, but if there's not enough pixels, it will have uneven gaps.

OpenType hinting is not as good as TrueType, so there's less control for these situations.

Also the ScreenSmart versions are better designed for displays, so they look much better.

I have my font size set to 17px but I'm also using a 4K display. Try playing around with font size and see if that helps.

TheBotlyNoob commented 3 years ago

upped the font size, still looks more like monospace than Operator Mono

(normal Operator Mono)

kiliman commented 3 years ago

Can you email me the generated fonts? kiliman@gmail.com

TheBotlyNoob commented 3 years ago

if I look at it in the windows previewer it looks fine

kiliman commented 3 years ago

Yeah, I just think that VS Code is using the Light weight. Try increasing fontWeight.

TheBotlyNoob commented 3 years ago

the fontWeight is at bold

kiliman commented 3 years ago

Are you using the numbers? Like "editor.fontWeight": "400"

Otherwise, I'm not sure what the problem is then.

TheBotlyNoob commented 3 years ago

No, same thing

TheBotlyNoob commented 3 years ago

Works now! I dont know what changed.