kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code
MIT License
3.2k stars 202 forks source link

Only two fonts in build folder #180

Closed Jeferson-Emanuel closed 2 years ago

Jeferson-Emanuel commented 2 years ago

After renaming all the fonts following the name format recommended and running the build commando, I got only 4 files in the build folder:

OperatorMonoLig-BookItalic.otf OperatorMonoLig-LightItalic.otf OperatorMonoLig-BookItalic.ttx OperatorMonoLig-LightItalic.ttx

Running Windows 10.

kiliman commented 2 years ago

Hmm. For regular Operator Mono (not ScreenSmart), we only have the 2 weights: Book and Light. However, you should have gotten 2 more OTF files: OperatorMonoLig-Book.otf and OperatorMono-Light.otf.

Can you show me the files you put in the ./original folder?

Jeferson-Emanuel commented 2 years ago

Sorry for not updating here previously. I followed the instructions in issue #169 and renamed the files following the model you posted there.

My original folder look like this:

image

My build folder look like this now:

image

After installing them, I tried to use the Operator Mono SSM Lig and got this:

image

Seems like only the de non SSM versions work with the ligatures.

This is what I see in my Fonts folder:

image

kiliman commented 2 years ago

Hmm.. interesting. If you look at your Operator "Mono" SSm.... it's actually Operator SSm (the non-mono version). This is why the metrics are all wrong. You can see that the characters don't line up in nice even columns.

image
Jeferson-Emanuel commented 2 years ago

Interesting. I probably messed up when I was copying the names from your model and pasting in the font names in the original folder.

I will look in the name inside the files to find the correct ones, rename it the right way and run the build.bat again.

Thanks.

Jeferson-Emanuel commented 2 years ago

Updating here. All working now. I really had renamed the wrong font files.

A suggestion to avoid further issues with it would be to make your script detect which font is which automatically. The need to rename the files in a very specific and exact way will be prone to errors by the user.

Thanks. =)

kiliman commented 2 years ago

Hmm.. well that's how the fonts were named when I purchased them, so not sure why it would be a problem.

Anyway, glad you figured it out.