search

kiliman / operator-mono-lig

Add ligatures to Operator Mono similar to Fira Code
MIT License
3.2k stars 202 forks source link

VScode === showing different space between lines #96

Closed urielzen closed 5 years ago

urielzen commented 5 years ago

Operator Mono Lig Light In VSCode in Windows, the triple equal sign shows the two spaces between the lines one thicker than the other.

This happens with the default VSCode font size of 14. And default zoom.

image

I have no scaling setup for my apps in Windows image

mskelton commented 5 years ago

@urielzen What font variation are you using? I.e. ssm book, ssm light, etc.

dannymcgee commented 5 years ago

This is a hinting issue. Buying a high-DPI monitor or adjusting the font size are the easiest ways to fix it. It's impossible to do the sort of granular hinting you would need to do to fix this dev-side without switching to TTF.

kiliman commented 5 years ago

Yes, it's difficult to get horizontal and vertical bars to be evenly space at small font sizes. Even with hinting, the rasterizer simply doesn't have enough pixels to align stuff. I find that 16+ font size gives enough pixels.

Plus the Mac uses anti-aliasing and not hinting to kind of smooth the edges. TrueType hinting may have better control, but unfortunately we're only supporting the OpenType font.

How does Fira Code look at the same font size?

urielzen commented 5 years ago

FiraCode has the same issue but only with Light

Fira Code Regular image

Fira Code Medium image

Fira Code Light image

kiliman commented 5 years ago

The light fonts are so thin, it is very noticeable when the bars are not aligned perfectly. It's hard when you have to generate a line that is 1.2 pixels thick with a 2.1 pixel gap (just example numbers).

Anyway, I did rework that glyph in v2.2.2, so see if that makes any difference. Also, what happens when you bump the font size?

urielzen commented 5 years ago

with version 2.2.2 the bigger space moved to the bottom image

Making the font 15 size shows correctly, but it has obvious problem that there is less code in the screen.

Going all the way down to 12 also shows correctly, but it is just too small to read.

I cannot afford a high-DPI monitor so I'll just have to live with this one.

I understand this is a difficult issue to solve. You can go ahead and close it if you'd like. I just thought in bringing this up since it happens with the default font size in vscode, which I would think most people probably use.

Thanks