Fix last segment finding on Windows (#37)

kiliman / remix-flat-routes

Remix package to define routes using the flat-routes convention

MIT License

739 stars 25 forks source link

Fix last segment finding on Windows (#37) #40

Closed wonu closed 1 year ago

wonu commented 1 year ago

When finding the last segment of routeIdWithoutRoutes to determine a route, '/' should be used instead of path.sep because routeIdWithoutRoutes has already been normalized by normalizeSlashes().

ben-smartbear commented 1 year ago

@kiliman any chance of getting this merged? It unblocked a Windows developer here who was encountering issues.

kiliman commented 1 year ago

Ugh. Sorry, I should know better since I use both macOS and Windows.

kiliman commented 1 year ago

Published as v0.5.8