search

kiliman / remix-flat-routes

Remix package to define routes using the flat-routes convention
MIT License
695 stars 24 forks source link

fix fixupIndexRoutes function args type #47

Open oats7777 opened 1 year ago

oats7777 commented 1 year ago

The type of parameter in the fixupIndexRoutes function changed from any to RouteManifest. This is because I think it is better to increase safety by specifying a specific type rather than using any in type script.

kiliman commented 1 year ago

I think we can remove this function altogether. This was here because an older version of Remix was checking for index routes by looking for route id ending with '/index'. Current versions now use the index flag from the route manifest.

oats7777 commented 1 year ago

I think we can remove this function altogether. This was here because an older version of Remix was checking for index routes by looking for route id ending with '/index'. Current versions now use the index flag from the route manifest.

Can I understand that after the PR below is merged, I can remove the function and make a new implementation that fits the new index flag from the route manager?

https://github.com/remix-run/remix/pull/3127