search

kiliman / remix-hydration-fix

Sample app that shows how to fix React hydration issues in a Remix app
119 stars 9 forks source link

Not working for `react-popper` #5

Open hanayashiki opened 1 year ago

hanayashiki commented 1 year ago

Using this in combination with a server-rendered component using react-popper hooks seems to lead to a wrong calculation of the offset.

kiliman commented 1 year ago

Thanks, but I'm not quite sure what you mean.

I actually recommend using the React canary version. The hydration errors have been fixed in the next release. If it's good enough for Next.js, then it's good enough for me.

hanayashiki commented 1 year ago

Thanks, but I'm not quite sure what you mean.

I actually recommend using the React canary version. The hydration errors have been fixed in the next release. If it's good enough for Next.js, then it's good enough for me.

I mean some DOM manipulation by this library might not be compatible with some other libraries.

My apps behave strangely after using this library, even though it indeed fixes problems introduced by chrome extensions. I also cannot risk using React canary because it is production environment.

kiliman commented 1 year ago

I see. The "hydration fix" is basically a hack. Like I said before, I recommend using the canary version as it fixes this at the React level.

According to the React team, canary versions are production-stable. Next.js v13+ has been using canaries in production for over a year.

https://react.dev/blog/2023/05/03/react-canaries

hanayashiki commented 1 year ago

I see. The "hydration fix" is basically a hack. Like I said before, I recommend using the canary version as it fixes this at the React level.

According to the React team, canary versions are production-stable. Next.js v13+ has been using canaries in production for over a year.

https://react.dev/blog/2023/05/03/react-canaries

Thank you, but I cannot find in which commit they fixed the hydration problem.