search

kiliman / remix-typedjson

This package is a replacement for superjson to use in your Remix app. It handles a subset of types that `superjson` supports, but is faster and smaller.
MIT License
435 stars 19 forks source link

Regenerate lock file #15

Closed memark closed 1 year ago

memark commented 1 year ago

Regenerate lock file. When cloning and running npm install the lock file is modified. These automatic updates should probably be committed.

kiliman commented 1 year ago

I'm confused. This is a library, so are you saying it's affecting the app's package.json?

Or are you trying to build this project locally and npm install is modifying the package.json?

I wonder if it has to do with the peer dependencies.

memark commented 1 year ago

I'm referring to when building this project locally.

Since this project has a package-lock.json I think it should be up to date with package.json. It only affects local development. This PR fixes that.

Some people argue (#1, #2) that libraries shouldn't have a package-lock.json at all (and I'm inclined to agree) but that's a different discussion.

kiliman commented 1 year ago

Ok, I think the problem was that I didn't have the peer dependencies listed in dev dependencies as well. Anyway pushed an update. Thanks!