search

kiliman / tailwindui-crawler

tailwindui-crawler downloads the component HTML files locally
MIT License
763 stars 95 forks source link

Added TailwindUI CDN build #1

Closed sonovice closed 4 years ago

sonovice commented 4 years ago

... so that opening an html file looks decent. Also, removed the leading and trailing underscores from filenames.

kiliman commented 4 years ago

Thanks for the PR. I agree that making it simple to view the actual component is helpful.

My main goal for building this tool was to be able to track changes made to the official components. By adding additional content to the HTML, I feel it may make it harder to keep in sync with upstream.

What do you think about keeping the original output as pristine, but add a secondary output that is decorated with additional markup?

./output => original components ./decorated => with additional markup

I would eventually like to add a transformer process that will convert the HTML markup to React components, so this would play nicely into that.

sonovice commented 4 years ago

Having two outputs would work as well, sure. But adding the very same line to every single component wouldn't break your goal of having change tracking abilities since that line would not change in the future. It would simply allow people to look at the stuff by opening it up in the browser.

Simply another use case, but they could be easily unified without sacrifices...

kiliman commented 4 years ago

True. We'll go with your change for now. Thanks!