search

kilkelly / react-passport-redux-example

Demonstration of PassportJS authentication in React w/ Redux.
MIT License
66 stars 12 forks source link

is there an interest in a PR with an upgrade to react packages? #6

Open zachi opened 6 years ago

zachi commented 6 years ago

hi, i forked the repo lately for a personal use. part of my work was to upgrade the following react packages

"react": "16.4.0", "react-dom": "16.4.0", "react-redux": "^5.0.6", "react-router": "^3.0.2", "react-router-redux": "^4.0.8", "redux": "^4.0.0", "redux-thunk": "^2.3.0"

would you like a pull request with this update? Zach

kilkelly commented 6 years ago

Hi @zachi as the repository is quite old now I hadn't intended on updating it. I would imagine some of the practices used are not best practices any more, especially when it comes to react and react-router. So I think I will leave it as it is and if it is still useful to others then that's good :)

By the way did the code still work for you once you upgraded to the new packages?

zachi commented 6 years ago

@kilkelly Im new to this environment (react, node, mongo :-), and needed user authentication mechanism to begin with, so this repo was an easy base to crash on. I had to update react class syntax: React.createClass => extends React.Component. Initialize state within the Ctor instead of using getInitialState and do some shuffling with the dependent packages. can you please give me a ref that will show the react-router practice change? In general. if you can think about other things that needs polishing..

zachi.