issues
search
killbill
/
killbill-admin-ui
Kill Bill Administrative UI engine
https://killbill.io
MIT License
52
stars
59
forks
source link
Remove Kernel's define_singleton_method patch
#372
Closed
hmnhf
closed
1 year ago
hmnhf
commented
1 year ago
This PR addresses
this comment
.
The patch was added in commit 23e8e181 back in 2012 to support
define_singleton_method
for Ruby 1.8.
Since
Ruby 1.8's EOL was in 2014
, and KAUI
requires Ruby 3.2.2+
, it should be safe to remove the patch.
I made sure all tests pass after the removal.
define_singleton_method
is only used in
TagDefinition
to define
TagDefinition.all_for_*
methods.
The defined methods are used in places like
account_tags#edit
which have
tests
.
define_singleton_method
is only used in TagDefinition to defineTagDefinition.all_for_*
methods.account_tags#edit
which have tests.