search

killbill / killbill-adyen-plugin

Kill Bill plugin for Adyen
https://killbill.io
Apache License 2.0
10 stars 31 forks source link

Applepay and googlepay transactions need to be ecommerce; need to sen… #105

Closed alenad closed 5 years ago

alenad commented 5 years ago

…d 'paymentdatasource.type' in additionalData field; removed not needed fields in the tests

@pierre @daliwei @sbrossie

pierre commented 5 years ago

@alenad Can you confirm the tests suites (profiles -Pmysql and -Pintegration-mysql) pass against the sandbox?

alenad commented 5 years ago

@alenad Can you confirm the tests suites (profiles -Pmysql and -Pintegration-mysql) pass against the sandbox?

@pierre sure, ran the tests: -Pmysql pass -Pintegration-mysql has same 5 failures in my branch as in backport-0.18.x

applepay-androidpay

Failed tests:

  TestAdyenPaymentPluginApiHPP.testAuthorizeAndExpireHppWithoutCompletion:111 expected [PT3H] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredBoletoPayment:280 expected [P7D] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredPayPalPayment:185 expected [P1D] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredPayPalPaymentNoNotification:217 expected [P1D] but found [PT12H]
  TestRemoteAdyenPaymentServiceProviderHostedPaymentPagePort.testDirectory:72 » NullPointer

backport-0.18.x Failed tests:

  TestAdyenPaymentPluginApiHPP.testAuthorizeAndExpireHppWithoutCompletion:111 expected [PT3H] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredBoletoPayment:280 expected [P7D] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredPayPalPayment:185 expected [P1D] but found [PT50M]
  TestAdyenPaymentPluginApiHPP.testCancelExpiredPayPalPaymentNoNotification:217 expected [P1D] but found [PT12H]
  TestRemoteAdyenPaymentServiceProviderHostedPaymentPagePort.testDirectory:72 » NullPointer

master

  TestAdyenPaymentPluginApiHPP>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
  TestKillbillAdyenNotificationHandler>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
  TestRemoteAdyenPaymentServiceProviderHostedPaymentPagePort>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
  TestAdyenDao>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument resource ad...
  TestAdyenPaymentPluginApi>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
  TestRemoteAdyenPaymentServiceProviderPort>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
  TestAdyenPaymentPluginHttpErrors>TestRemoteBase.setUpBeforeClass:101 » IllegalArgument
pierre commented 5 years ago

@alenad All of the tests are passing for me on both branches (they were also passing for @daliwei for the last PR, see https://github.com/killbill/killbill-adyen-plugin/pull/100#discussion_r249332404).

The reason I'm asking is that against our sandbox, which doesn't have ApplePay configured, the test is passing (and the test payment is shown as a MC co-branded card). It could be an odd behavior from the gateway but I want to make sure you verified your tests before we re-release again.